Outbound channel InterruptedException treatment

danielmkraus · June 7, 2021, 12:39pm

Hi all,

Checking the outbound channel code, I`ve verified that if we have an InterruptedException being thrown Flowable will continue the execution without raising any further exception, thus, the message sent will be considered as successfully delivered when it might not.

github.com

flowable/flowable-engine/blob/70447d2be8d7516541f67113bd15cd14a8d8e0a7/modules/flowable-event-registry-spring/src/main/java/org/flowable/eventregistry/spring/kafka/KafkaOperationsOutboundEventChannelAdapter.java#L41

    
      
                  this.kafkaOperations = kafkaOperations;
                  this.topic = topic;
                  this.key = key;
              }
          
          
    @Override
              public void sendEvent(String rawEvent) {
                  try {
                      kafkaOperations.send(topic, key, rawEvent).get();
                  } catch (InterruptedException e) {
                      Thread.currentThread().interrupt();
                  } catch (ExecutionException e) {
                      if (e.getCause() instanceof RuntimeException) {
                          throw (RuntimeException) e.getCause();
                      } else {
                          throw new FlowableException("failed to send event", e.getCause());
                      }
                  }
              }
          
          
}

joram · June 14, 2021, 3:22pm

How did you establish that? The current thread gets interrupted, so I assume this propagates upwards and marks the current operation as invalid?

filiphr · June 15, 2021, 5:31am

I had a deeper look and indeed interrupting the thread is not enough. The transaction won’t be rollbacked if we do that. Therefore, I’ve just pushed Throw an exception if the thread was interrupted while sending a Kafk… · flowable/flowable-engine@6ee746c · GitHub which will throw an exception if the sending was interrupted. We are doing a similar thing for other InterruptedException(s).

Topic		Replies	Views
Handle any Flowable-/ELException Flowable Engine	6	1645	July 6, 2018
Handling unexpected errors in integration with Kafka Flowable Engine	0	297	December 14, 2021
Flowable resume process instance upon receiving a Kafka event in a service task Flowable Engine	3	471	May 12, 2021
Configuring Send Event Task with Kafka Flowable Engine	1	126	August 16, 2023
Send/Receive tasks - using Kafka topics Flowable Engine	3	540	January 3, 2024

Outbound channel InterruptedException treatment

Related Topics