MyBatis is compiled with version 6

On 23Feb2017 a PR was pushed (a04e07622f226181f90cc548159f252410e91dd0) with the title “Fix schema and catalog issue for creating tables for dmn, form, and content engine”.

In the content source file I see this change (part of the larger change set):

From:

if (StringUtils.isNotEmpty(databaseSchema)) {

To:

if (StringUtils.isNotEmpty(dataSource.getConnection().getSchema())) {

The getSchema() method was introduced in JDK7. The MyBatis jar was compiled with JDK6 thus the following error message appears when running the tests in org.flowable.content.engine.test.ContentItemTest:

java.lang.AbstractMethodError: org.h2.jdbc.JdbcConnection.getSchema()Ljava/lang/String;

FWIW, despite what the PR comment states I don’t see this change in the DMN and Form engine files.

Hi David,

The changes in the DMN and Form Engine were reverted. Will make sure that it’s also reverted for the Content Engine. The issue is not MyBatis but the H2 JDBC driver being compiled with JDK 6.
By upgrading to the latest Liquibase version, the schema issue was already resolved.

Best regards,

Tijs

Tijs,

I’m not so sure about that. If you look at the console for this QA test, http://qa.flowable.org/job/Flowable6MySQL/156/console
which is running MySQL it appears to have the same issue.

Similar failure in the MSSQL test, http://qa.flowable.org/job/Flowable6MSSQL/155/console.

Cheers,
David

The change was reverted in this PR #278.