Bug in ExecutionEntityImpl.getRootProcessInstance()

Flowable Engine
1

Is it OK, that if rootProcessInstanceId is null than read rootProcessInstance? I think no.
Flowable v6.3.1

protected void ensureRootProcessInstanceInitialized() {
        if (rootProcessInstanceId == null) {
            rootProcessInstance = (ExecutionEntityImpl) CommandContextUtil.getExecutionEntityManager().findById(rootProcessInstanceId);
        }
    }
2

You are right this doesn’t seem right @Jakub_Ferschmann.

Are you using the getRootProcessInstance method?

Will you be willing to provide a PR with the fix for this?

Cheers,
Filip

3

Ok, I can fix it, but I don’t know what does it mean PR.

4

PR is a Pull Request. Here is some more information about it. In a nutshell it is a way for people to push changes from their own repositories / branches to a different repository / branch?

5

@filiphr @Jakub_Ferschmann
I submitted this pr.

https://github.com/flowable/flowable-engine/pull/1279

1 Like
6

Thanks @shareniu we’ll look into it