Should last name be added to PrivilegeMapping?

I notice that in LDAPIdentifyServiceImpl the getUsersWithPrivilege method sets the last name on the user object to the user id, like this:

User user = new UserEntityImpl();
user.setId(privilegeMapping.getUserId());
user.setLastName(privilegeMapping.getUserId());
users.add(user);

Thinking that might be a bug, I went and looked at PrivilegeMapping and I see that the last name isn’t actually available in that class.

The impact of this is that when you look at the privileges page, the name column shows the user ID not the user name.

Hi Jeff,

Yes indeed. We have to decide if we want to duplicate some user info in the privilege mapping table to solve this. Of course, this is only so in the LDAP use case. Would you prefer to duplicate the user info?

Best regards,

Tijs